Remove the deprecated mirage_v2 alias#61
Merged
Conversation
mirage_v2 aliased lucy-restyle-2. Removes it from RealTimeModels, MODEL_ALIASES and _MODELS; repoints the affected unittests to lucy-2.1-vton-2. Breaking: models.realtime('mirage_v2') now raises ModelNotFoundError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mirage_v2 aliased lucy-restyle-2. Removes it from RealTimeModels, MODEL_ALIASES and _MODELS; repoints the affected unittests to lucy-2.1-vton-2. Breaking: models.realtime('mirage_v2') now raises ModelNotFoundError.
Note
Medium Risk
Intentional breaking API change: any integration still passing
mirage_v2tomodels.realtime()will fail at runtime.Overview
Removes the deprecated
mirage_v2realtime model name, which previously aliasedlucy-restyle-2. It is dropped fromRealTimeModels,MODEL_ALIASES, and the realtime_MODELSregistry.Breaking:
models.realtime("mirage_v2")no longer resolves and will raiseModelNotFoundError. Callers should uselucy-restyle-2(or another supported realtime name).Deprecation-related tests now use
lucy-2.1-vton-2→lucy-vton-2instead ofmirage_v2.Reviewed by Cursor Bugbot for commit b2c2e45. Bugbot is set up for automated code reviews on this repo. Configure here.